Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fixes for things that changed with the Katsu UUID fix #6

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Add fixes for things that changed with the Katsu UUID fix #6

merged 1 commit into from
Dec 19, 2023

Conversation

OrdiNeu
Copy link
Collaborator

@OrdiNeu OrdiNeu commented Dec 13, 2023 •
edited by jira bot
Loading

Ticket(s)

Description

  • Fix issues that cropped up when using the new Katsu. This requires the data-portal changes as well

Expected Behaviour

  • The search page works as it did before, but with the new Katsu schemas.

Related Issues (if appropriate)

Types of Change(s)

  • 🪲 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)

@OrdiNeu OrdiNeu mentioned this pull request Dec 13, 2023
Merged
10 tasks
@OrdiNeu OrdiNeu force-pushed the fnguyen/uuid-fix branch 2 times, most recently from 4ed2655 to 49aa245 Compare December 14, 2023 21:28
CourtneyGosselin
CourtneyGosselin approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@CourtneyGosselin CourtneyGosselin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OrdiNeu OrdiNeu merged commit 5eeb286 into develop Dec 19, 2023
1 check passed
@OrdiNeu OrdiNeu deleted the fnguyen/uuid-fix branch December 19, 2023 19:00
@OrdiNeu OrdiNeu mentioned this pull request Jan 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CourtneyGosselin CourtneyGosselin CourtneyGosselin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OrdiNeu @CourtneyGosselin