Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use authorized counts where available for patient counts / data vis #174

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

OrdiNeu
Copy link
Contributor

@OrdiNeu OrdiNeu commented Aug 23, 2024

Ticket(s)

Description

  • Improves the patient counts and data visualization by substituting in real data from the clinical results where available

Screenshots (if appropriate)

Using skin and being logged in as User 2 (who has access to SYNTH_02 but nothing else):

Before PR

image

After PR

image

Types of Change(s)

  • 🪲 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)

Has it been tested for:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • Prettier linter doesn't return errors
  • Production branch PR browser testing: Chrome, Firefox, Edge, etc.
  • Locally tested
  • Dev server tested
  • Production tested when merging into stable/production branch
  • Runbook tasks pass locally/on UHN-Dev
  • If visuals have changed, Runbook has been updated with new screenshots

@OrdiNeu OrdiNeu changed the title Bugfix/authorized counts Use authorized counts where available for patient counts / data vis Aug 23, 2024
Copy link
Member

@CourtneyGosselin CourtneyGosselin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Just an ESlint warning to be fixed

@OrdiNeu OrdiNeu merged commit 41649e3 into develop Aug 26, 2024
4 checks passed
@OrdiNeu OrdiNeu deleted the bugfix/authorized-counts branch August 26, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants