Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch "number of samples" to "number of donors" #141

Closed
wants to merge 1 commit into from

Conversation

OrdiNeu
Copy link
Contributor

@OrdiNeu OrdiNeu commented May 3, 2024

Description

  • The "Complete Genomic" graph in both the summary page and completeness stats page has an x axis of "samples" instead of donors

Screenshots (if appropriate)

After PR

image

Types of Change(s)

  • 🪲 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)

Has it been tested for:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • Prettier linter doesn't return errors
  • Production branch PR browser testing: Chrome, Firefox, Edge, etc.
  • Locally tested
  • Dev server tested
  • Production tested when merging into stable/production branch
  • Runbook tasks pass locally/on UHN-Dev
  • If visuals have changed, Runbook has been updated with new screenshots

@OrdiNeu OrdiNeu requested a review from mshadbolt May 3, 2024 21:09
@OrdiNeu
Copy link
Contributor Author

OrdiNeu commented May 3, 2024

Close in favor of #140

@OrdiNeu OrdiNeu closed this May 3, 2024
@OrdiNeu OrdiNeu deleted the bugfix/genomic-samples-not-donors branch May 3, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant