Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Spatial_selection.ipynb notebook #278

Merged
merged 4 commits into from
Sep 4, 2023

Conversation

hrsdawson
Copy link
Collaborator

Closes #272

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@navidcy navidcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to move this example into "Tutorials". What do you think @hrsdawson?

I also noticed that at the top there is a broken link to the map tutorial; could we fix that in this PR?

@review-notebook-app
Copy link

review-notebook-app bot commented Sep 4, 2023

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2023-09-04T01:30:54Z
----------------------------------------------------------------

Line #8.    #from pint import application_registry as ureg
Line #9.    #import cf_xarray.units

delete commented lines?


@review-notebook-app
Copy link

review-notebook-app bot commented Sep 4, 2023

View / edit / reply to this conversation on ReviewNB

julia-neme commented on 2023-09-04T04:13:53Z
----------------------------------------------------------------

Link to tutorial on working with projections not working!


Copy link
Collaborator

@julia-neme julia-neme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per comments

@review-notebook-app
Copy link

review-notebook-app bot commented Sep 4, 2023

View / edit / reply to this conversation on ReviewNB

julia-neme commented on 2023-09-04T04:21:00Z
----------------------------------------------------------------

I think the colormap could be prettier!


@navidcy
Copy link
Collaborator

navidcy commented Sep 4, 2023

Nice! I moved it to Tutorials.

@navidcy navidcy merged commit b9ec8c8 into COSIMA:main Sep 4, 2023
1 of 2 checks passed
@access-hive-bot
Copy link

This pull request has been mentioned on ACCESS Hive Community Forum. There might be relevant details there:

https://forum.access-hive.org.au/t/cosima-hackathon-v3-0-monday-september-4th-2023/1186/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Update Spatial_selection.ipynb notebook
4 participants