Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EASI-4551 Add a system team member #2819

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Conversation

adamodd
Copy link
Contributor

@adamodd adamodd commented Sep 18, 2024

EASI-4551

https://www.figma.com/design/z8GeZPDfIh9oKfHK1cX7Fo/System-centric-EASi?node-id=1008-9405&node-type=frame&t=HoeR8NMkJqIvmowW-0

Description

  • The team member form now has a workspace mode
    • useIsWorkspaceParam will check for the ?workspace mode
  • The system profile team form remains the same

How to test this change

  • Make sure the systemWorkspaceTeam flag is on
  • Go to the system workspace team card
  • Add a member to see the changes

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@adamodd adamodd changed the title Easi 4551/add team member EASI-4551 Add a system team member Sep 18, 2024
@adamodd adamodd marked this pull request as ready for review September 18, 2024 21:23
@adamodd adamodd requested a review from a team as a code owner September 18, 2024 21:23
@adamodd adamodd requested review from aterstriep and removed request for a team September 18, 2024 21:23
Remove the attempted lookup for a more isolated team member form
Copy link
Collaborator

@ClayBenson94 ClayBenson94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the pre-selected roles when adding a team member who's already part of a team works as expected, but it seems like if you manually clear that selection (or adjust the team member name to a member who's not part of the team) it doesn't clear the list of roles

Thinking it might be worth just clearing out the Team member role(s) dropdown on basically any input selection on Team member name

Kapture 2024-09-20 at 09 46 19

@adamodd
Copy link
Contributor Author

adamodd commented Sep 20, 2024

@ClayBenson94 Manually clearing that field does not seem to update the value when I reference watch('euaUserId'). This reference to the input field value is only updated when a different user is selected.

@aterstriep Is there another path to catching the manual clearing of the multiselect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants