Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds proper dynamic linking #69

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ libc = "0.2"
bindgen = "0.60"
camino = "1.0.9"
once_cell = "1.12"
regex = "1.5"

[target.'cfg(not(windows))'.build-dependencies]
pkg-config = "0.3"
Expand Down
55 changes: 39 additions & 16 deletions build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ pub struct EnvVars {
out_dir: Option<PathBuf>,
ffmpeg_include_dir: Option<PathBuf>,
ffmpeg_dll_path: Option<PathBuf>,
ffmpeg_multi_arch_build: Option<PathBuf>,
ffmpeg_pkg_config_path: Option<PathBuf>,
ffmpeg_libs_dir: Option<PathBuf>,
ffmpeg_binding_path: Option<PathBuf>,
Expand All @@ -192,6 +193,9 @@ impl EnvVars {
ffmpeg_pkg_config_path: env::var("FFMPEG_PKG_CONFIG_PATH").ok().map(remove_verbatim),
ffmpeg_libs_dir: env::var("FFMPEG_LIBS_DIR").ok().map(remove_verbatim),
ffmpeg_binding_path: env::var("FFMPEG_BINDING_PATH").ok().map(remove_verbatim),
ffmpeg_multi_arch_build: env::var("FFMPEG_MULTI_ARCH_BUILD")
.ok()
.map(remove_verbatim),
}
}
}
Expand Down Expand Up @@ -266,29 +270,48 @@ mod windows {
}

fn dynamic_linking(env_vars: &EnvVars) {
let re = regex::Regex::new(r"\w*.(so|dylib|dll)$").unwrap();
let ffmpeg_dll_path = env_vars.ffmpeg_dll_path.as_ref().unwrap();

let output_binding_path = &env_vars.out_dir.as_ref().unwrap().join("binding.rs");

// Extract dll name and the dir the dll is in.
let (ffmpeg_dll_name, ffmpeg_dll_dir) = {
let mut ffmpeg_dll_path = PathBuf::from(ffmpeg_dll_path);
// Without extension.
let ffmpeg_dll_filename = ffmpeg_dll_path.file_stem().unwrap();
let ffmpeg_dll_name = if cfg!(target_os = "windows") {
ffmpeg_dll_filename
let lib_name_filter = |mut file_name: String| -> Option<String> {
if re.is_match(file_name.as_str()) {
file_name = file_name.replace("lib", "");
file_name = file_name.replace(".so", "");
file_name = file_name.replace(".dylib", "");
file_name = file_name.replace(".dll", "");
Some(file_name)
} else {
ffmpeg_dll_filename.trim_start_matches("lib")
None
}
.to_string();
// Remove file name.
ffmpeg_dll_path.pop();
let ffmpeg_dll_path = ffmpeg_dll_path.to_string();
(ffmpeg_dll_name, ffmpeg_dll_path)
};
if env_vars.ffmpeg_multi_arch_build.as_ref().is_none() {
for file in std::fs::read_dir(ffmpeg_dll_path).unwrap() {
let file_name = file.unwrap().file_name().into_string().unwrap();
let file_name = lib_name_filter(file_name);
if let Some(f) = file_name {
println!("cargo:rustc-link-lib=dylib={}", f);
}
}
Copy link

@SimonRacaud SimonRacaud Aug 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing rustc-link-search ?
++ println!("cargo:rustc-link-search=native={}", ffmpeg_dll_path);

} else {
let base_path = env::var("FFMPEG_LIBS_DIR").ok().unwrap();
let target_os = env::var("CARGO_CFG_TARGET_OS").ok().unwrap();
let target_arch = env::var("CARGO_CFG_TARGET_ARCH")
.ok()
.unwrap()
.replace("arm", "armeabi-v7a")
.replace("aarch64", "arm64-v8a");
let per_arch_path = format!("{}/{}/{}/lib", base_path, target_os, target_arch);

println!("cargo:rustc-link-lib=dylib={}", ffmpeg_dll_name);
println!("cargo:rustc-link-search=native={}", ffmpeg_dll_dir);
println!("cargo:rustc-link-search=native={}", per_arch_path);
for file in std::fs::read_dir(per_arch_path).unwrap() {
let file_name = file.unwrap().file_name().into_string().unwrap();
let file_name = lib_name_filter(file_name);
if let Some(f) = file_name {
println!("cargo:rustc-link-lib=dylib={}", f);
}
}
}

if let Some(ffmpeg_binding_path) = env_vars.ffmpeg_binding_path.as_ref() {
use_prebuilt_binding(ffmpeg_binding_path, output_binding_path);
Expand Down