Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init - new builder page #34

Merged
merged 6 commits into from
Sep 30, 2024
Merged

init - new builder page #34

merged 6 commits into from
Sep 30, 2024

Conversation

ishtails
Copy link
Contributor

Your ENS/address: ishtails.eth

@vercel Vercel
Copy link

vercel bot commented Sep 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
batch9-buidlguidl-com-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 9:28am

@ishtails
builder page ready
221ef1f 
- created new builder page
- cleaned up old files
@ishtails ishtails marked this pull request as ready for review September 25, 2024 15:48
@ishtails
Copy link
Contributor Author

Screenshot for reference:

Screenshot (436)
Screenshot (437)

phipsae
phipsae requested changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@phipsae phipsae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your builder page looks amazing, very nice work! :)

It would be great if you could remove the builder with the address 0x059E31Ea8A88b62FE1603CCE134eF7c1cC557395—that's my account which I used to mint your new graduation NFT.

Below are my comments.

packages/nextjs/app/builders/page.tsx Outdated Show resolved Hide resolved
packages/nextjs/app/builders/page.tsx Show resolved Hide resolved
packages/nextjs/app/builders/page.tsx Show resolved Hide resolved
packages/nextjs/app/builders/page.tsx Show resolved Hide resolved
@phipsae
Copy link
Collaborator

phipsae commented Sep 30, 2024

Thx a lot, for the changes!

I noticed that for builders who haven't created a personal page, clicking the link currently leads to a 404 error. It would be great to display a test in the BuilderCard like 'No builder page available' and disable the link functionality in such cases.

Let me know if you'd like to make this change, otherwise, I'm happy to merge as it is.

@ishtails
Copy link
Contributor Author

Thx a lot, for the changes!

I noticed that for builders who haven't created a personal page, clicking the link currently leads to a 404 error. It would be great to display a test in the BuilderCard like 'No builder page available' and disable the link functionality in such cases.

Let me know if you'd like to make this change, otherwise, I'm happy to merge as it is.

sure, let me do that quickly just like the home page...

@ishtails
added check for builder page
22b48ff 
- created hook for checking builder page
- implemented in builder page Cards
@phipsae
Copy link
Collaborator

phipsae commented Sep 30, 2024

Thx and merged!

@phipsae phipsae merged commit 0a78e9d into BuidlGuidl:main Sep 30, 2024
3 checks passed
@ishtails
Copy link
Contributor Author

cheers! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phipsae phipsae phipsae requested changes

Assignees

@ishtails ishtails

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishtails @phipsae