Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and cleaning #28

Merged
merged 8 commits into from
Jul 9, 2023
Merged

Refactoring and cleaning #28

merged 8 commits into from
Jul 9, 2023

Conversation

obackhouse
Copy link
Contributor

Lots of code cleanup and some minor refactoring to simplify things, improved docstrings, also flake8 linting.

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2023

Codecov Report

Patch coverage: 93.69% and project coverage change: -0.03 ⚠️

Comparison is base (47e2058) 99.58% compared to head (ef81d05) 99.56%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   99.58%   99.56%   -0.03%     
==========================================
  Files          54       54              
  Lines       85707    85708       +1     
  Branches      724      817      +93     
==========================================
- Hits        85355    85333      -22     
- Misses        237      249      +12     
- Partials      115      126      +11     
Impacted Files Coverage Δ
ebcc/__init__.py 98.73% <ø> (ø)
ebcc/ansatz.py 80.58% <ø> (-0.19%) ⬇️
ebcc/space.py 91.26% <ø> (ø)
ebcc/util.py 70.44% <75.47%> (-1.04%) ⬇️
ebcc/rebcc.py 86.09% <89.58%> (-1.31%) ⬇️
ebcc/reom.py 94.30% <97.22%> (+0.08%) ⬆️
ebcc/uebcc.py 96.79% <97.24%> (-0.67%) ⬇️
ebcc/brueckner.py 90.69% <100.00%> (+0.10%) ⬆️
ebcc/dump.py 86.17% <100.00%> (-0.96%) ⬇️
ebcc/eris.py 86.07% <100.00%> (+0.36%) ⬆️
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@obackhouse obackhouse merged commit 089db65 into master Jul 9, 2023
4 checks passed
@obackhouse obackhouse deleted the cleanup branch July 9, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants