Expand job listing search

[gikaragia]

Fixes #2749

Overview

There are many requests for improving the job search functionality in #1707. The most frequent one being to allow an 'OR' operator when searching. So if for example, a user enters 'software engineer' in search then the listings that contain either 'software' or 'engineer' should be returned. I don't think that we should make this the default behavior as:

• WP core search uses terms with an AND operator which means that it returns posts that contain both terms.
• From a user perspective the AND seems more useful as it allows to filter through many results. I would expect when adding more terms to make the search more specific than the other way around.
  If we want to ever allow this, we should specifically support 'OR' and 'AND' operators.

Another, confusing part is that WP core search does partial searches which means that if someone searches for "Java" it will return listings that contain "JavaSript".

Finally, there are also the issues mentioned in #2749. We currently also search the meta fields but not in a consistent way with core. We also don't support negations (-) and phrase searches ("") for meta fields and categories.

This PR solves the issues in #2749 by providing the same functionality for meta and term searches with WP Core (which searches title content and excerpt). This means that for meta and categories:

• We now split search terms and look for each one individually.
• Each term has to exist to at least one of the metas, categories, post title, content and excerpt.
• Users can perform reverse searches with the minus sign e.g. -intern
• Users can perform phrase searches e.g. "software developer"

Changes Proposed in this Pull Request

• get_job_listings_keyword_search had been reimplemented to construct the search clause from the beginning. Initially, I tried solutions that appended to the existing search clause, but it wasn't possible to achieve accurate results as the core search clauses belonged to a different combination of ANDs and ORs
• Now the SQL produced for each search term looks like this:

( ( wp_posts.post_title LIKE '%engineer%' )
                OR ( wp_posts.post_excerpt LIKE '%engineer%' )
                OR ( wp_posts.post_content LIKE '%engineer%' )
                OR wp_posts.id IN (SELECT post_id
                                   FROM   wp_postmeta
                                   WHERE  meta_key IN
                                          ( '_application',
                                            '_company_name'
                                            ,
                                            '_company_tagline',
                                                    '_company_website',
                                            '_company_twitter'
                                          )
                                          AND meta_value LIKE '%engineer%')
                OR wp_posts.id IN (SELECT object_id
                                   FROM   wp_term_relationships AS tr
                                          LEFT JOIN wp_term_taxonomy AS tt
                                                 ON tr.term_taxonomy_id =
                                                    tt.term_taxonomy_id
                                          LEFT JOIN wp_terms AS t
                                                 ON tt.term_id = t.term_id
                                   WHERE  t.name LIKE '%engineer%') )
AND ( ( wp_posts.post_title LIKE '%engin%' ) .....

• WP core limits the search terms count to 9 so I don't think that there is a risk for the query to become too large.
• I removed the job_listing_search_conditions hook as it wasn't possible to maintain anymore. Users can always override the whole get_job_listings_keyword_search function with the previous version to revert to the previous functionality.

Testing Instructions

• Add listings that contain possible search terms in the title, post content, excerpt, job category, and job metas (e.g. company name or tagline)
• Go to the frontend and perform various searches.
• Try using minus sign and double quotes, especially for meta fields and job categories.
• Try using category search and term search from the term plugin together with search terms.
• Observe that:
  • Each search term is included to at least one of the searched columns.
  • When using exclusion terms, observe that these are applied last.

Release Notes

• Expand job meta and category searching with core WordPress search functionality.

New or Updated Hooks and Templates

job_listing_search_conditions: Removed as it isn't possible to have it anymore. Users can rollback to previous functionality by overriding get_job_listings_keyword_search in wp-job-manager-functions.php

Next Steps

Regarding further improvements in job listing search in general I think that we should avoid them as I think that the implementation is already complex. Any future steps should instead focus on integrating with well known plugins that expand core WP search.

---

Plugin build for 07706c2
📦 Download plugin zip
▶️ Open in playground

[yscik]

Working great! Added a few questions and noticed one issue, but generally code looks good too.

[yscik]

One more big improvement to the search would be to prioritize matches in the title — and generally to sort results by relevance. Maybe we could do multiple searches, first just in the post title, then in content, metas? It could actually be faster for the first pages in some cases, since if there are enough results in the title, we don't need to do the content/meta searches.

Just bringing it up to discuss here, it'd be its own PR probably as there would be some extra complexity, like handling pagination. Could also do some weighting maybe?

[gikaragia]

In this PR I focused on fixing what seemed like buggy behavior. Although we included some meta fields in searches, it didn't work as expected previously and returned weird results.

One more big improvement to the search would be to prioritize matches in the title — and generally to sort results by relevance. Maybe we could do multiple searches, first just in the post title, then in content, metas? It could actually be faster for the first pages in some cases, since if there are enough results in the title, we don't need to do the content/meta searches.
Just bringing it up to discuss here, it'd be its own PR probably as there would be some extra complexity, like handling pagination. Could also do some weighting maybe?

These are great suggestions, there is a lot of room for improvement. We could look into implementing these in the future. Another option would be to integrate with plugins that expand WP's search capabilities as it has been suggested in the past.