Simplify Github release CI code #1883
Conversation
| - name: Create release | ||
| if: contains(github.ref, 'refs/tags/') | ||
| id: create_release | ||
| uses: actions/create-release@v1 | ||
| uses: softprops/action-gh-release@v1 |
There was a problem hiding this comment.
| uses: softprops/action-gh-release@v1 | |
| uses: softprops/action-gh-release@6034af24fba4e5a8e975aaa6056554efe4c794d0 |
There was a problem hiding this comment.
How can we trust this author? I feel a bit scared always using these third-party modules that have minified js code... almost would like to build code myself from source and review code.
There was a problem hiding this comment.
Good question. It was one of the 4 actions recommended from Github's action repo. It was the one with most stars and forks, and looks like it's being constantly maintained.
There was a problem hiding this comment.
It's pity that Github does not take responsibility of maintaining this kind of useful basic tools...
There was a problem hiding this comment.
I'm just seeing that the source files are TypeScript. Isn't the minified js file just TypeScript processed? We could quite easily fork and do that process ourselves I think
|
I'm not sure if this should be closed even if we can't merge it directly because I'm afraid old code might stop working some time in the future (contains deprecating api). |
Reason for this
actions/create-releaseis no longer maintainedNote
I have not tested it here, but used the same way I did in other personal code