Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#356: Added username sanitation. #365

Merged
merged 3 commits into from
Apr 4, 2024
Merged

#356: Added username sanitation. #365

merged 3 commits into from
Apr 4, 2024

Conversation

FranSlot
Copy link
Contributor

@FranSlot FranSlot commented Apr 4, 2024

Fixes #356.

@FranSlot FranSlot linked an issue Apr 4, 2024 that may be closed by this pull request
Bug mysql database after creation prototype #356
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
1 0 0 1 100

Passed Tests

Name ⏱️ Duration Suite
Should be able to access the Home page 0 s RAPLive

hanjoosten
hanjoosten requested changes Apr 4, 2024
View reviewed changes
Copy link
Member

@hanjoosten hanjoosten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the comments you tell what the statement below does. That is hardly info the reader of your code needs to know. Please tell why (the purpose) of doing what is done here.
In this case, why do we need to sanitize the username?

@FranSlot FranSlot requested a review from hanjoosten April 4, 2024 12:38
hanjoosten
hanjoosten approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@hanjoosten hanjoosten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super!

@FranSlot FranSlot merged commit 4eb197b into main Apr 4, 2024
4 checks passed
@FranSlot FranSlot deleted the bug/356-bug-mysql-database-after-creation-prototype branch April 4, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanjoosten hanjoosten hanjoosten approved these changes

@KlaasDijkstraOrdina KlaasDijkstraOrdina Awaiting requested review from KlaasDijkstraOrdina

Assignees

@KlaasDijkstraOrdina KlaasDijkstraOrdina

Labels
bug: normal prio RAP5
Projects
A-team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug mysql database after creation prototype
3 participants
@FranSlot @hanjoosten @KlaasDijkstraOrdina