Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create bookmarks using query parameters #226

Merged
merged 5 commits into from
Aug 8, 2023

Conversation

tobisupreme
Copy link
Contributor

@tobisupreme tobisupreme commented Aug 8, 2023

This PR...

Changes

  • Bookmarks no longer have a title
  • Bookmarks are created using query parameters i.e

POST /bookmarks?postId=id-of-content-to-bookmark&postType=postType
where postType is one of 'Answer', 'Comment', 'Post', or 'Question'

  • To delete multiple bookmarks at a go, send a DELETE request to
    /bookmarks/bulk-delete. It's payload is an object with a property of bookmarkIds. The value is an array with at least one bookmarkId
  {
    "bookmarkIds": ["bookmarkId1", "bookmarkId2", "bookmarkId3"]
  }

Checklist

  • tested locally
  • added new dependencies
  • updated the Swagger API docs
  • updated the Postman collection
  • added a test
  • linter passes
  • format check passes

Fixes #227

@tobisupreme tobisupreme temporarily deployed to Pre-deployment August 8, 2023 10:13 — with GitHub Actions Inactive
@tobisupreme tobisupreme requested review from Boye95, Skywonda and a team and removed request for Skywonda August 8, 2023 10:22
@tobisupreme tobisupreme marked this pull request as ready for review August 8, 2023 10:31
Copy link
Contributor

@Boye95 Boye95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tobisupreme

@Boye95 Boye95 merged commit 00cb080 into dev Aug 8, 2023
1 check passed
@tobisupreme tobisupreme deleted the create-bookmarks-with-query-parameters branch August 8, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Bookmark contents using query params as a means of passing data to the API
2 participants