Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair requirements.txt #559

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Repair requirements.txt #559

merged 3 commits into from
Aug 1, 2023

Conversation

dl1com
Copy link
Contributor

@dl1com dl1com commented Aug 1, 2023

Reinsert PyQt5 and PyInstaller requirements, although already covered by fbs 1.2.1

@dl1com
Copy link
Contributor Author

dl1com commented Aug 1, 2023

Tests run fine now.

Although these lines makes me a bit nervous:

Collecting PyQt5~=5.12 (from -r requirements.txt (line 2))
  Downloading PyQt5-5.15.9-cp37-abi3-manylinux_2_17_x86_64.whl (8.4 MB)

Collecting PyInstaller~=4.1 (from -r requirements.txt (line 3))
  Downloading pyinstaller-4.10-py3-none-manylinux2014_x86_64.whl (1.5 MB)

So it seems that ~= does not have the intended effect to allow only patch-level updates here.
Perhaps we should stick with exact version pinning (==)?

@dl1com dl1com requested a review from t0mpr1c3 August 1, 2023 15:57
@t0mpr1c3
Copy link
Contributor

t0mpr1c3 commented Aug 1, 2023

Tests run fine now.

Although these lines makes me a bit nervous:

Collecting PyQt5~=5.12 (from -r requirements.txt (line 2))
  Downloading PyQt5-5.15.9-cp37-abi3-manylinux_2_17_x86_64.whl (8.4 MB)

Collecting PyInstaller~=4.1 (from -r requirements.txt (line 3))
  Downloading pyinstaller-4.10-py3-none-manylinux2014_x86_64.whl (1.5 MB)

So it seems that ~= does not have the intended effect to allow only patch-level updates here. Perhaps we should stick with exact version pinning (==)?

Probably safer. Best to do it in the fbs fork as well.

Reinsert PyQt5 and PyInstaller requirements, although already covered by fbs 1.2.1
use exact version pinning
Use exact version for pyserial as well
@dl1com dl1com merged commit 3f702a1 into 1.0.0-dev Aug 1, 2023
2 checks passed
@dl1com dl1com deleted the dl1com-patch-1 branch August 1, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants