Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement effect_list for pmfbj lights #1205

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Implement effect_list for pmfbj lights #1205

merged 1 commit into from
Nov 8, 2023

Conversation

JonathanKang
Copy link
Contributor

No description provided.

@AlexxIT
Copy link
Owner

AlexxIT commented Nov 7, 2023

Why you using mode and effect simultaneously?

@JonathanKang
Copy link
Contributor Author

Why you using mode and effect simultaneously?

The MapConv("mode", "select"... is for creating a select entity for selecting light effects. As effect_list has been implemented, this is not necessary. I'll remove this.

@AlexxIT AlexxIT merged commit da2da37 into AlexxIT:master Nov 8, 2023
1 of 2 checks passed
@AlexxIT
Copy link
Owner

AlexxIT commented Nov 8, 2023

Thanks!

@AlexxIT AlexxIT added this to the v3.3.5 milestone Jan 5, 2024
@AlexxIT
Copy link
Owner

AlexxIT commented Jan 5, 2024

https://github.com/AlexxIT/XiaomiGateway3/releases/tag/v3.3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.5
Development

Successfully merging this pull request may close these issues.
2 participants
@JonathanKang @AlexxIT