Update redirects.md #44
Conversation
Fit the paths indentation. Add a warning note about the defaults being changed breaking ece-tools URLs scenario.
Co-authored-by: Jared Hoover <98363870+jhadobe@users.noreply.github.com>
I have now signed the CLA. |
| >[!NOTE] | ||
| > | ||
| >If the `http://{default}/:` type is not set to `upstream`, `ece-tools` can encounter issues configuring URL routes in `core_config_data` tables. | ||
| > | ||
| >```yaml | ||
| >http://{default}/: | ||
| > type: upstream | ||
| >``` | ||
|
|
There was a problem hiding this comment.
@dannystaple I've been unable to confirm this internally. If you revert this change, I can merge the updates to the indentation.
There was a problem hiding this comment.
This change is relating to how the routing table ends up in the steps called by https://github.com/magento/ece-tools/blob/2002.1/src/Step/Deploy/InstallUpdate/ConfigUpdate/Urls.php.
In UrlManager, https://github.com/magento/ece-tools/blob/2002.1/src/Util/UrlManager.php, it tries to read the initial URL as primary. However, https://github.com/magento/ece-tools/blob/2002.1/src/Util/UrlManager.php#L84 will skip a URL if it's type is not upstream.
If the primary is not this default, then the execute function in https://github.com/magento/ece-tools/blob/2002.1/src/Step/Deploy/InstallUpdate/ConfigUpdate/Urls/Database.php will potentially find no URL's, or try to work with a subdomain, and then does not call updateUrl in line 81 correctly. You would then not have environment URLs in the database after a deployment (unless you updated them previously).
Purpose of this pull request
This pull request (PR):
Affected pages
Links to Commerce code