Include and Exclude characters shouldn't have a character limit, add …

…some constants for sizes common between Forms and Models

scripts/constants.py

@@ -0,0 +1,3 @@
+# A list of constants that should be consistent across database/form usage
+MAX_SCRIPT_NAME_LENGTH=100
+MAX_AUTHOR_NAME_LENGTH=100

scripts/forms.py

@@ -5,7 +5,7 @@
 from django.core.validators import FileExtensionValidator
 from versionfield import Version
 
-from scripts import models, script_json, validators, widgets
+from scripts import constants, models, script_json, validators, widgets
 
 
 class JSONError(Exception):
@@ -17,8 +17,8 @@ def tagOptions():
 
 
 class ScriptForm(forms.Form):
-    name = forms.CharField(max_length=100, required=False, label="Script name")
-    author = forms.CharField(max_length=30, required=False)
+    name = forms.CharField(max_length=constants.MAX_SCRIPT_NAME_LENGTH, required=False, label="Script name")
+    author = forms.CharField(max_length=constants.MAX_AUTHOR_NAME_LENGTH, required=False)
     script_type = forms.ChoiceField(
         choices=models.ScriptTypes.choices, initial=models.ScriptTypes.FULL
     )
@@ -153,13 +153,13 @@ class Meta:
 
 
 class AdvancedSearchForm(forms.Form):
-    name = forms.CharField(max_length=100, required=False)
-    author = forms.CharField(max_length=30, required=False)
+    name = forms.CharField(max_length=constants.MAX_SCRIPT_NAME_LENGTH, required=False)
+    author = forms.CharField(max_length=constants.MAX_AUTHOR_NAME_LENGTH, required=False)
     script_type = forms.ChoiceField(
         choices=models.ScriptTypes.choices, initial=models.ScriptTypes.FULL
     )
-    includes_characters = forms.CharField(max_length=30, required=False)
-    excludes_characters = forms.CharField(max_length=30, required=False)
+    includes_characters = forms.CharField(required=False)
+    excludes_characters = forms.CharField(required=False)
     edition = forms.ChoiceField(
         choices=models.Edition.choices, initial=models.Edition.CLOCKTOWER_APP
     )

scripts/models.py

@@ -2,6 +2,7 @@
 from django.db import models
 from versionfield import VersionField
 
+from scripts import constants
 from scripts.managers import ScriptViewManager, CollectionManager
 from typing import Dict
 
@@ -64,7 +65,7 @@ class Script(models.Model):
     A named script that can have multiple ScriptVersions
     """
 
-    name = models.CharField(max_length=100)
+    name = models.CharField(max_length=constants.MAX_SCRIPT_NAME_LENGTH)
     owner = models.ForeignKey(
         User, blank=True, null=True, on_delete=models.SET_NULL, related_name="+"
     )
@@ -92,7 +93,7 @@ class ScriptVersion(models.Model):
     script_type = models.CharField(
         max_length=20, choices=ScriptTypes.choices, default=ScriptTypes.FULL
     )
-    author = models.CharField(max_length=100, null=True, blank=True)
+    author = models.CharField(max_length=constants.MAX_AUTHOR_NAME_LENGTH, null=True, blank=True)
     version = VersionField()
     content = models.JSONField()
     pdf = models.FileField(null=True, blank=True, upload_to=determine_script_location)