Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-json] Migrate SNS ListSubscriptions #317

Conversation

kojisaikiAtSony
Copy link
Contributor

No description provided.

@kojisaikiAtSony kojisaikiAtSony changed the base branch from master to feature-aws-json August 7, 2024 05:11
@kojisaikiAtSony kojisaikiAtSony changed the title [aws-json] Add sns list subscriptions support [aws-json] Migrate SNS ListSubscriptions Aug 7, 2024
@kojisaikiAtSony
Copy link
Contributor Author

Hi @Admiral-Piett can you please review this?

Copy link
Owner

@Admiral-Piett Admiral-Piett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny thing, otherwise looks great!

smoke_tests/sns_list_subscriptions_test.go Outdated Show resolved Hide resolved
add bad request ut case to listsubscriptionsv1

rename listSubscriptions test case

review ref
@kojisaikiAtSony kojisaikiAtSony force-pushed the add_sns_list_subscriptions_support branch from 64c78ea to f7595ad Compare August 16, 2024 08:34
Copy link
Owner

@Admiral-Piett Admiral-Piett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thank you!

@Admiral-Piett Admiral-Piett merged commit aa31fa4 into Admiral-Piett:feature-aws-json Aug 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants