Piston bugfix #713
Merged
Piston bugfix #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It could be possible that cancelling these events has some adverse effects.
Also removed debug messages
TylerS1066
approved these changes
Sep 14, 2024
|
I am going to merge this, but we should consider a deep look at how we move tile entity ticks to try and resolve this, rather than patch the symptoms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe in detail what your pull request accomplishes
This pull request fixes a bug where moving pistons could become softlocked on a craft if they were activated during its movement step. It also removes older fixes to the problem which could cause a craft to become permanently obstructed by its own pistons.
Checklist