IS-05 Requirements for NMOS Controllers #148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-r-thorpe
changed the title
cristian-recoseanu
requested changes
Mar 25, 2022
garethsb
reviewed
Apr 12, 2022
Co-authored-by: Peter Brightwell <peter.brightwell@bbc.co.uk> Co-authored-by: cristian-recoseanu <cristian.recoseanu@hotmail.com>
garethsb
reviewed
Apr 19, 2022
Co-authored-by: cristian-recoseanu <cristian.recoseanu@hotmail.com>
garethsb
reviewed
Apr 19, 2022
garethsb
reviewed
Apr 19, 2022
garethsb
reviewed
Apr 19, 2022
garethsb
reviewed
Apr 20, 2022
garethsb
reviewed
Apr 20, 2022
garethsb
reviewed
Apr 20, 2022
garethsb
reviewed
Apr 26, 2022
garethsb
reviewed
May 10, 2022
garethsb
force-pushed
the
jonathan-r-thorpe-nmos-controller
branch
from
d764672
to
f015123
Compare
garethsb
added a commit
to garethsb/nmos-device-connection-management
that referenced
this pull request
May 12, 2022
Based on AMWA-TV#148 Co-authored-by: Jonathan Thorpe (Sony) <Jonathan.Thorpe@sony.com> Co-authored-by: Peter Brightwell <peter.brightwell@bbc.co.uk> Co-authored-by: cristian-recoseanu <cristian.recoseanu@hotmail.com>
garethsb
added a commit
to garethsb/nmos-device-connection-management
that referenced
this pull request
May 12, 2022
Based on AMWA-TV#148 Co-authored-by: Jonathan Thorpe (Sony) <Jonathan.Thorpe@sony.com> Co-authored-by: Peter Brightwell <peter.brightwell@bbc.co.uk> Co-authored-by: cristian-recoseanu <cristian.recoseanu@hotmail.com>
|
Approved and squashed for final review as #154. Congratulations and thank you, @jonathan-r-thorpe and the Controller Specification activity group. |
peterbrightwell
added a commit
that referenced
this pull request
Jun 23, 2022
* Publish NMOS Controller Based on #148 Co-authored-by: Jonathan Thorpe (Sony) <Jonathan.Thorpe@sony.com> Co-authored-by: Peter Brightwell <peter.brightwell@bbc.co.uk> Co-authored-by: cristian-recoseanu <cristian.recoseanu@hotmail.com> * Clarify required Controller behaviour w.r.t. Receiver sender_id and Sender receiver_id Change "SHOULD" to "can" in related Interop IS-04 paragraph, since a Node has no way to verify and enforce this * Clarify sentence * Apply suggestions from review * Remove sentence whose meaning is now captured more precisely in the previous section * Add missing statement about disconnect using IS-04 /target * Remove redundant sentences. * More minimal * Consistent language * Paragraph break * tweak language * Fix link Co-authored-by: Peter Brightwell <peter.brightwell@bbc.co.uk> Co-authored-by: Jonathan Thorpe (Sony) <Jonathan.Thorpe@sony.com> Co-authored-by: Peter Brightwell <peter.brightwell@bbc.co.uk> Co-authored-by: cristian-recoseanu <cristian.recoseanu@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of section for requirements specific to NMOS Controllers, based on the work done in the AWMA NMOS Controller Specification meetings.