Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing three subtle bugs with numerics in problem files. #103

Merged
merged 3 commits into from
Dec 29, 2023

Conversation

haz
Copy link
Contributor

@haz haz commented Dec 28, 2023

Fixes

Does two important things to address #99 and another bug found:

  1. NUMBER was matching on anything with a space (so 5 3 was a single number)
  2. The f-expressions in the problem file were pointing back to the domain definition, and thus trying to wrap in Variables.
  3. (update) Added another fix for Support equality comparison for numerics in problem goals #101, which now allows equality in metric goal conditions.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (514d568) 88.10% compared to head (260fe74) 88.33%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   88.10%   88.33%   +0.22%     
==========================================
  Files          25       25              
  Lines        1791     1791              
  Branches      332      332              
==========================================
+ Hits         1578     1582       +4     
+ Misses        154      149       -5     
- Partials       59       60       +1     
Flag Coverage Δ
unittests 88.33% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@haz haz changed the title Fixing two subtle bugs with numerics in problem files. Fixing three subtle bugs with numerics in problem files. Dec 29, 2023
Copy link
Collaborator

@francescofuggitti francescofuggitti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@haz haz merged commit 7a0132d into AI-Planning:main Dec 29, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants