Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creation of MACECalculator without needing to write a checkpoint to disk. #535

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

CompRhys
Copy link

@CompRhys CompRhys commented Jul 27, 2024

The current MACECalculator requires you to load from a particular structure of checkpoint file. If we use a different training framework our checkpoints are not compatible and so it would be nice to be able to just pass in models.

Still needs tests.

@ilyes319
Copy link
Contributor

ilyes319 commented Aug 6, 2024

Hey @CompRhys, can you give more context to that PR, I don't understand what you mean by checkpoint or model and training framework.

@CompRhys
Copy link
Author

CompRhys commented Aug 6, 2024

Sure, by checkpoint I mean a serialised file written to disk, by model I mean something like ShiftScaleMACE instantiated as an object, by training framework I mean something like pytorch lightning or accelerate. The checkpoint state dict for pytorch lightning cannot be loaded directly by this calculator instead requiring me to load the checkpoint access the model attribute save a compatible checkpoint to disk and then load the calculator with the path to that second compatible checkpoint. Resaving and reloading is unnecessary imo

@CompRhys
Copy link
Author

CompRhys commented Sep 5, 2024

@ilyes319 is there any pathway to this being merged?

@CompRhys CompRhys reopened this Sep 25, 2024
@ilyes319 ilyes319 merged commit 6586161 into ACEsuit:develop Sep 26, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants