Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Save and Recover Project Information #255

Merged
merged 11 commits into from
Sep 14, 2024
Merged

WIP: Save and Recover Project Information #255

merged 11 commits into from
Sep 14, 2024

Conversation

cortner
Copy link
Member

@cortner cortner commented Sep 13, 2024

moving PR #247 to this repo to collaborate on it.

@cortner
Copy link
Member Author

cortner commented Sep 13, 2024

@CheukHinHoJerry -- ready to continue on this. I was in a rush didn't manage to fully resolve the conflicts on save_potential - please take a look.

@CheukHinHoJerry
Copy link
Collaborator

No problem. Thanks for moving this.

@CheukHinHoJerry
Copy link
Collaborator

CheukHinHoJerry commented Sep 13, 2024

I will add test for recovering the manifest and project later too. Are those changes in the Project.toml intended?

@cortner
Copy link
Member Author

cortner commented Sep 13, 2024

Are those changes in the Project.toml intended?

What changes? Removing EmpiricalPotentials and UFACE - yes, that was intended (for now). UFACE will be deleted permanently but EP I'll probably bring back over the weekend.

@CheukHinHoJerry
Copy link
Collaborator

This PR is ready for review.

@cortner
Copy link
Member Author

cortner commented Sep 14, 2024

thank you, Jerry!

@cortner cortner merged commit ed2c3a9 into main Sep 14, 2024
2 checks passed
@cortner cortner deleted the saveproject branch September 14, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants