Tweaks following a full pass through the documentation #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yes. Thanks for spotting this. |
|
Just pushed a fix for the loss function - let's see how it renders. |
|
This looks like I should merge, yes? |
This is the only lingering item, but not essential to fix it now. Fine to merge if you like. |
|
I'll merge this and let's file an issue to integrate smoothness priors into runfits as well as update the tutorials. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall, everything in the
devdocs is pretty clean. A few small things:The weights should be squared here, right?
There is one TODO in the smoothness prior tutorial
