Call Unalias() in IsNilable() to support gotypesalias=1
#3304
+43
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Gilad Maymon <gilad.maymon@wiz.io>
noamcohen97
force-pushed
the
fix_isnilable
branch
from
891a170
to
1aeff60
Compare
noamcohen97
commented
Sep 27, 2024
codegen/config/binder.go
Outdated
| @@ -520,6 +520,7 @@ func (b *Binder) CopyModifiersFromAst(t *ast.Type, base types.Type) types.Type { | |||
| } | |||
|
|
|||
| func IsNilable(t types.Type) bool { | |||
| t = code.Unalias(t) | |||
There was a problem hiding this comment.
Maybe we should call types.Unalias(t) so we'll Unalias even in Go 1.22?
Currently in Go 1.22 calling this with a nilable alias type returns false.
@StevenACoffman, @a8m WDYT?
There was a problem hiding this comment.
We really need to continue to support Go 1.22, and I don't think we can just assume people have gotypesalias=1
There was a problem hiding this comment.
So I'll call types.Unalias() here, that way we'll make sure IsNilable() is reliable no matter what.
Also - we don't need the pointer base type unaliasing from code.Unalias() here.
|
Thanks! I really appreciate your fix here! Looking forward to your next contribution! |
|
Thanks @StevenACoffman! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed false
IsNilable()value for any (or any other aliased type) whengotypesalias=1(default since Go 1.23.0)Fixes #3301
I have: