Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.23 support #3226

Merged
merged 9 commits into from
Aug 22, 2024
Merged

Conversation

UnAfraid
Copy link
Contributor

Added support for *types.Alias conditionally only applies to go1.23
Also updated GitHub Actions to run the pipelines with go 1.23

Describe your PR and link to any relevant issues.
Closes #3222

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@coveralls
Copy link

coveralls commented Aug 22, 2024

Coverage Status

coverage: 74.498% (-0.1%) from 74.606%
when pulling 4031b99 on UnAfraid:feature/go1.23-support
into f6a8220 on 99designs:master.

@StevenACoffman
Copy link
Collaborator

StevenACoffman commented Aug 22, 2024

Thanks! I made some minor changes.

The coverage breaks if you run it for more than one version because coveralls will only accept the first one.

Also the matrix is already pretty slow, and current version + one previous seems sufficient for support.

@StevenACoffman StevenACoffman merged commit 6acc182 into 99designs:master Aug 22, 2024
17 checks passed
@UnAfraid UnAfraid deleted the feature/go1.23-support branch August 22, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on code generation
3 participants