#85 Override executed script #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ExecutionMode.FORCE_MARK_AS_EXECUTED is now deprecated. Use Action.MARK_AS_EXECUTED. - ExecutionStatus.FORCE_MARKED_AS_EXECUTED is deprecated. The action is saved on the executed script - ExecutionStatus.SHOULD_BE_EXECUTED was removed because useless now we have action
Lysoun
requested changes
Feb 10, 2021
There was a problem hiding this comment.
Since this can't be in a review comment, I'm telling here: the action of DatamaintainConfig should be added in the log function of the class.
I don't see anything regarding the new option for the configuration to enable Datamaintain to choose to override executed scripts, is that normal?
modules/core/src/main/kotlin/datamaintain/core/config/DatamaintainConfig.kt
Outdated
Show resolved
Hide resolved
modules/core/src/main/kotlin/datamaintain/core/script/Script.kt
Outdated
Show resolved
Hide resolved
modules/core/src/main/kotlin/datamaintain/core/script/FileScript.kt
Outdated
Show resolved
Hide resolved
modules/core/src/main/kotlin/datamaintain/core/step/executor/Executor.kt
Outdated
Show resolved
Hide resolved
modules/core/src/main/kotlin/datamaintain/core/step/executor/Executor.kt
Outdated
Show resolved
Hide resolved
...datamaintain/core/step/sort/ByCaseInsensitiveSeparatorFreeAlphabeticalSortingStrategyTest.kt
Show resolved
Hide resolved
modules/driver-mongo/src/test/kotlin/datamaintain/db/driver/mongo/InMemoryScript.kt
Outdated
Show resolved
Hide resolved
nroulon
approved these changes
Feb 23, 2021
Lysoun
reviewed
Feb 23, 2021
| val set = "\$set"; | ||
|
|
||
| executeMongoQuery(""" | ||
| db.$EXECUTED_SCRIPTS_COLLECTION.update({ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override executed script
Resolves/Fixes/Closes #85