Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New cluster] Kitware #3929

Merged
merged 10 commits into from
Apr 11, 2024
Merged

Conversation

GeorgianaElena
Copy link
Member

Ref #3906

Also updates some things in the docs while walking through them.

Copy link

github-actions bot commented Apr 10, 2024

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
aws kitware Yes Following helm chart values files were modified: enc-support.secret.values.yaml, support.values.yaml No

Production deployments

No production hub upgrades will be triggered

Comment on lines -54 to -65
````{warning}
If you are deploying the support chart on an AWS cluster, you **must** enable the `cluster-autoscaler` sub-chart, otherwise the node groups will not automatically scale.
Include the following in your `support.values.yaml` file:

```yaml
cluster-autoscaler:
enabled: true
autoDiscovery:
clusterName: <cluster-name>
awsRegion: <aws-region>
```
````
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@consideRatio, apparently it was still documented, I might have missed it when deploying dandi. Anyway, I've removed it now that we autogenerate it via the deployer.

Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add the 8cpu gpu option, then copy paste from recent hub setups will work well. I think it makes sense to provide both in general i guess. Out of scope from doing it by the docs though.

Lgtm no matter what!

@GeorgianaElena
Copy link
Member Author

Thank you @consideRatio 🚀

Maybe add the 8cpu gpu option, then copy paste from recent hub setups will work well. I think it makes sense to provide both in general i guess.

Wasn't sure what to do about this, but tried not to assume and followed the docs as close as possible as an experiment. As long as we can add it later, if it's explicitly required, I think it's fine.

We can also add it las a general good practice in the docs as you said.

@GeorgianaElena GeorgianaElena merged commit db09da7 into 2i2c-org:main Apr 11, 2024
9 checks passed
@GeorgianaElena GeorgianaElena deleted the docs-update branch April 11, 2024 07:51
Copy link

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/8643319425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants