Skip to content
This repository has been archived by the owner on Jun 25, 2023. It is now read-only.

solution #5

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

solution #5

wants to merge 3 commits into from

Conversation

khushpatel2002
Copy link

No description provided.

solution/helm/Dockerfile Outdated Show resolved Hide resolved
autotests/helm/values.yaml Outdated Show resolved Hide resolved
@darknessest
Copy link
Collaborator

@khushpatel2002, could you please update your endpoint to accept only texts and not a dict with a field text?
See this output:

{"detail":[{"loc":["body"],"msg":"value is not a valid dict","type":"type_error.dict"}]}
INFO:     127.0.0.1:35130 - "POST /process HTTP/1.1" 422 Unprocessable Entity

The expected format is shown in this sample curl

@khushpatel2002
Copy link
Author

@khushpatel2002, could you please update your endpoint to accept only texts and not a dict with a field text? See this output:

{"detail":[{"loc":["body"],"msg":"value is not a valid dict","type":"type_error.dict"}]}
INFO:     127.0.0.1:35130 - "POST /process HTTP/1.1" 422 Unprocessable Entity

The expected format is shown in this sample curl

Endpoint have been updated according to the sample

Copy link
Collaborator

@rsolovev rsolovev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @khushpatel2002 , thank you for your wonderful solution. Here are our tests results on a grafana dashboard.

If you would like to work on your solution further, you can continue optimizing/improving it and re-request our review once done. Any contribution during the challenge period will be taken into account while choosing a winner. Many thanks!

P.S I'll add a separate comment for your second PR a bit later

electriclizard added a commit that referenced this pull request Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants