Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libs/regex_to_circom #184

Merged
merged 3 commits into from
Mar 30, 2024
Merged

Remove libs/regex_to_circom #184

merged 3 commits into from
Mar 30, 2024

Conversation

saleel
Copy link
Member

@saleel saleel commented Mar 25, 2024

Description

Remove libs/regex_to_circom in favour of zk-regex
Git maintains the history in case needed. URL

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have discussed with the team prior to submitting this PR
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@saleel saleel mentioned this pull request Mar 25, 2024
@Divide-By-0
Copy link
Member

Divide-By-0 commented Mar 26, 2024

I think there's a few mentions left in the readmes?
Screenshot_20240325_225037_Chrome

@saleel
Copy link
Member Author

saleel commented Mar 26, 2024

They are commented out in the docs.
I have removed them anyway.

@Divide-By-0 Divide-By-0 self-requested a review March 29, 2024 19:57
@Divide-By-0
Copy link
Member

Good to merge after resolving merge conflicts!

@saleel saleel merged commit 6d0acdd into main Mar 30, 2024
5 checks passed
@saleel saleel deleted the refactor/clean-libs branch March 30, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants