Merge pull request #200 from zkemail/pr/fix-regex-circom

[BUG FIX] Fix SelectRegexReveal
zkemail · May 28, 2024 · 8ea11a0 · 8ea11a0
2 parents 4626ff5 + e56f511
commit 8ea11a0
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/circuits/utils/regex.circom b/packages/circuits/utils/regex.circom
@@ -11,15 +11,15 @@ include "./bytes.circom";
 /// @param maxRevealLen Maximum length of the reveal part
 /// @input in Input array; assumes elements to be bytes
 /// @input startIndex The index from which reveal part starts; assumes a valid index, 
-///                   and `startIndex + maxRevealLen - 1` fits in `ceil(log2((maxArrayLen))` bits.
+///                   and `startIndex + maxRevealLen - 1` fits in `ceil(log2((maxArrayLen + maxRevealLen - 1))` bits.
 /// @output out Revealed data array
 template SelectRegexReveal(maxArrayLen, maxRevealLen) {
     signal input in[maxArrayLen];
     signal input startIndex;
 
     signal output out[maxRevealLen];
 
-    var bitLength = log2Ceil(maxArrayLen);
+    var bitLength = log2Ceil(maxArrayLen + maxRevealLen - 1);
 
     signal isStartIndex[maxArrayLen];
     signal isZero[maxArrayLen];