Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making this work for times less than 1 day #3

Open
gampleman opened this issue Oct 5, 2015 · 4 comments
Open

Making this work for times less than 1 day #3

gampleman opened this issue Oct 5, 2015 · 4 comments

Comments

@gampleman
Copy link
Contributor

every 15 seconds would be pretty excellent if supported.

What would need to be done to get that working?

@yb66
Copy link
Owner

yb66 commented Oct 6, 2015

Hi @gampleman

To be honest, I'm not sure. Work on this got sidelined for a while for other things. There is updated code on the develop branch, take a look there instead of the master. If you provide a spec for it, that would be the most helpful thing to get started, and then I could give it a go asap.

Regards,
iain

@yb66
Copy link
Owner

yb66 commented Oct 13, 2015

Hi @gampleman

I've just pushed some changes to the develop branch that the specs say handle "3 seconds". You can either choose "seconds" or "sec" but not "second", as that clashes with other ordinals. I haven't looked at anything for the other specs you added. Let me know if you find a problem.

Regards
iain

@gampleman
Copy link
Contributor Author

Looks ok, but the every other seconds use case doesn't make much sense. Can we not exploit context to disambiguate the ordinal from the unit?

@yb66
Copy link
Owner

yb66 commented Oct 13, 2015

every other second

every second day

every second

I think that’s going to be a tough ask the way the library is designed right now. I’d love to replace what’s there with a proper parser that could handle things like this more easily, but that’s down the road. I’ll give it a try, but don’t get your hopes up.

Regards,
iain

On 13 Oct 2015, at 12:29, Jakub Hampl notifications@github.com wrote:

Looks ok, but the every other seconds use case doesn't make much sense. Can we not exploit context to disambiguate the ordinal from the unit?


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants