Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failed: Expression: all((1 * u"turn" ≈ q * u for (q, u) = zip(quantities, units))) #38

Closed
Hellseher opened this issue Dec 10, 2023 · 2 comments

Comments

@Hellseher
Copy link

Hi,

During preparing your project for Guix downstream I've faced with failing tests:

Test Failed at /gnu/store/y0jimlwdn54jkqiicdwsjlp0jbb7marz-julia-unitfulangles-0.7.1/share/julia/loadpath/UnitfulAngles/test/runtests.jl:9
  Expression: all((1 * u"turn" ≈ q * u for (q, u) = zip(quantities, units)))
ERROR: LoadError: There was an error during testing
in expression starting at /gnu/store/y0jimlwdn54jkqiicdwsjlp0jbb7marz-julia-unitfulangles-0.7.1/share/julia/loadpath/UnitfulAngles/test/runtests.jl:9
  • Julia v1.8.3
  • UnitfulAngles.jl v0.7.1
  • Unitful.jl v1.12.2
@cmichelenstrofer
Copy link
Collaborator

cmichelenstrofer commented Dec 10, 2023

Ah, this was introduced by #34 and I missed it when I fixed the pas issue in dcc079a.

It should be fixed now (v0.7.2), @Hellseher can you verify it works for you if you update to v0.7.2?

This points to a larger issue that the tests are not checked as part of CI. The GitHub workflows in this repo are outdated. I just created a new issue (#39) for this.

@Hellseher
Copy link
Author

Hi @cmichelenstrofer,

Thanks for so quick response and fix, it's working like a charm now. Now all
phases are passed with tests enabled and patch is preparing for review to be
included in Guix.

Thanks,
Oleg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants