Implement progressive call results #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muzzammilshahid
force-pushed
the
progressive-call-results
branch
2 times, most recently
from
9269cf5
to
8b674ce
Compare
om26er
requested changes
Sep 20, 2024
| import ( | ||
| "context" | ||
| "fmt" | ||
| "github.com/xconnio/xconn-go" |
There was a problem hiding this comment.
should be arranged correctly. the CI should have failed
session.go
Outdated
| req <- &CallResponse{msg: result} | ||
| progress, _ := result.Details()["progress"].(bool) | ||
| if progress { | ||
| if progressHandler, exists := s.progressHandlers.Load(result.RequestID()); exists { |
There was a problem hiding this comment.
should be assigned first and tested later.
| receiveProgress, _ := invocation.Details()["receive_progress"].(bool) | ||
| if receiveProgress { | ||
| inv.SendProgress = func(arguments []any, kwArguments map[string]any) error { | ||
| yield := messages.NewYield(invocation.RequestID(), map[string]any{"progress": true}, arguments, kwArguments) |
There was a problem hiding this comment.
should refer to the const that's created in the dealer.go
muzzammilshahid
force-pushed
the
progressive-call-results
branch
from
8b674ce
to
227026d
Compare
om26er
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
download..