Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WindowMaker should allow dragging of apps which are NOT running into the dock... (new feature) #17

Open
gcasa opened this issue Aug 18, 2021 · 7 comments

Comments

@gcasa
Copy link

gcasa commented Aug 18, 2021

It should be possible to drag app icons into the dock from GWorkspace.

@gryf gryf added enhancement New feature or request and removed enhancement New feature or request labels Aug 19, 2021
@gryf
Copy link
Member

gryf commented Aug 19, 2021

I'm not sure if this issue belong to Window Maker. In wmaker alone, you are able to add app icons to the dock just fine. IMHO this issue should be reported to GWorkspace instead.

@gcasa
Copy link
Author

gcasa commented Aug 20, 2021

It seems that the duty to accept or reject a drag is on the receiver. I will make a short video to illustrate what I am talking about, if needed. Here is the use case I am after:

  1. The user starts wmaker with the dock..
  2. the user starts GWorkspace and navigates to where .apps are installed for GNUstep
  3. The user drags an app from GWorkspace to the dock

Current behavior: The dock does not accept the drag
Desired behavior: The dock should accept the drag and add it to the dock.

Currently, the only way to add an app to the dock is to run the application and then drag that active application (running app) into the dock and that way it is added. On NeXTSTEP and OPENSTEP adding apps to the dock was possible whether the app was currently running or not.

WindowMaker is a wonderful piece of software and this would be a nice to have. If you can give me any advice that would allow wmaker to accept the drag OR help me implement this for wmaker OR help you guys implement it then that would be super awesome.

Thanks.... full disclosure I'm the lead developer/maintainer of GNUstep. GC

@d-torrance
Copy link
Member

I like this idea. Maybe it could even be extensible, like if a certain filetype is dragged to the dock, Window Maker could check to see if the user has installed a script to tell it how to turn it into an appicon. In addition to GNUstep apps, there might be one for XDG .desktop files.

@gcasa
Copy link
Author

gcasa commented Aug 21, 2021

Hey guys. Let me know if you're going to implement this or give me some guidance on how to do this myself. Thanks.

@d-torrance
Copy link
Member

This sounds like a fun feature to work on, and I might take a stab at it at some point, but I can't promise that it would be any time soon.

If you'd like to try, then you might start poking around in src/dock.c. I'm not certain that's the correct spot, but that's where I would start looking.

@gcasa
Copy link
Author

gcasa commented Aug 27, 2021

This sounds like a fun feature to work on, and I might take a stab at it at some point, but I can't promise that it would be any time soon.

If you'd like to try, then you might start poking around in src/dock.c. I'm not certain that's the correct spot, but that's where I would start looking.

I believe I have found the relevant functions. I will make a fork and submit a pr when done.

@d-torrance
Copy link
Member

I believe I have found the relevant functions. I will make a fork and submit a pr when done.

FYI, this Github repo is essentially just the bug tracker. Any patches should be sent (via git send-email) to wmaker-dev@googlegroups.com. See https://github.com/window-maker/wmaker/blob/master/The-perfect-Window-Maker-patch.txt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants