Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run phan on composer 1.x? #210

Open
reedy opened this issue Feb 24, 2021 · 3 comments
Open

Run phan on composer 1.x? #210

reedy opened this issue Feb 24, 2021 · 3 comments

Comments

@reedy
Copy link
Member

reedy commented Feb 24, 2021

Following up on #204... Do we care about running phan against composer 1.x?

It'll add some complexity, and maybe isn't necessary...
@reedy reedy mentioned this issue Feb 25, 2021
Open
@mcaskill
Copy link
Contributor

mcaskill commented Feb 25, 2021 •
edited
Loading

I'm unfamiliar with Phan, its configuration, and features, but I think we can ignore Composer 1, if that is possible. If it's just as much as pain to ignore it as to support it 🤷‍♂️.

@reedy
Copy link
Member Author

reedy commented Feb 25, 2021 •
edited
Loading

I've basically ignored 1.x in 8a275c4 with the @phan-suppress-next-line commands.

If we try and run it on 1.x, we end up needing conditional suppression and other fun things.

It's definitely not impossible, it's just more work. And as I mentioned in #212, it's probably not going to be unreasonable to drop 1.x support in the near future anyway..

@reedy
Copy link
Member Author

reedy commented Aug 22, 2022

#243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcaskill @reedy