Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filename like this [xxxxxx.vtt?language=en] not works #8

Open
msongz opened this issue Mar 27, 2020 · 3 comments
Open

filename like this [xxxxxx.vtt?language=en] not works #8

msongz opened this issue Mar 27, 2020 · 3 comments

Comments

@msongz
Copy link

msongz commented Mar 27, 2020

will rename to xxxxx.vtt.[ext]?language=en

@whyboris
Copy link
Owner

whyboris commented Mar 27, 2020

Sorry, the app expects normal file names and extensions, like xxxxx.vtt.

Just so I understand, your original file name was:
xxxxxx.vtt?language=en
And it got renamed to
xxxxxx.vtt.[ext]?language=en
?

@msongz
Copy link
Author

msongz commented Mar 28, 2020

yeah,i want to rename the file from xxxxxx.vtt?language=en to xxxxxx.srt
but it fail

@whyboris
Copy link
Owner

Thank you for clarifying!

The way I detect extensions is path.parse(file);

https://github.com/whyboris/Simplest-File-Renamer/blob/master/src/app/home/home.component.ts#L247

I'm unsure what's going wrong here. I'm currently more-eager to work on Video Hub App:
https://github.com/whyboris/Video-Hub-App

Pull requests are welcome for fixing this edge case 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants