Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test vectors #36

Closed
Mischala opened this issue May 14, 2019 · 5 comments
Closed

Test vectors #36

Mischala opened this issue May 14, 2019 · 5 comments
Labels
good first issue Good for newcomers

Comments

@Mischala
Copy link

Adding some test vectors may be helpful to ensure internal consistency.

  • few vectors for expanding Secrets into Keypairs, and comparing a known result
  • few vectors for signing a payload and comparing to a known result
  • few vectors for verifying a result we know should correctly verify
@burdges
Copy link
Collaborator

burdges commented May 14, 2019

We'll need them eventually of course. I'd accept PRs for them now. And we've commented out code that gives a starting point.

I've only just made a bunch of breaking changes, so test vectors would've made no sense before now. We could either add some now, as this might be the last batch of breaking changes, or else wait until we get a bit more feedback.

Ideally, we might do #26 before adding test vectors so as to suggest breaking optimizations. I halfway implemented #26 once before though so I think the only breaking optimizations is already done in https://github.com/w3f/schnorrkel/blob/master/src/vrf.rs#L736

@burdges burdges added the good first issue Good for newcomers label May 14, 2019
@burdges
Copy link
Collaborator

burdges commented May 14, 2019

In any case, I think benchmarks are a much higher priority. We'll always support merlin, and should've test vectors, but we might recommend alternative hashing with Shake128 or Blake2x instead of merlin. See #33

@burdges
Copy link
Collaborator

burdges commented Jul 9, 2019

We should be ready to settle on test vectors around early August.

@burdges
Copy link
Collaborator

burdges commented Jul 31, 2019

We've settled everything so this can proceed.

@burdges
Copy link
Collaborator

burdges commented Aug 5, 2019

I'll close in favor of #43

@burdges burdges closed this as completed Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants