Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build errors and update to react 18 #377

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Fix build errors and update to react 18 #377

merged 3 commits into from
Aug 9, 2024

Conversation

JakeWags
Copy link
Member

@JakeWags JakeWags commented Aug 8, 2024

Does this PR close any open issues?

Closes none

Give a longer description of what this PR addresses and why it's needed

This PR fixes semantic build errors (unused/undefined import, etc) and updates storybook and react dependencies to react 18.

Unsure of why, but after building with the latest main (tried in a new directory and clone) build fails unless react is updated to 18. This may be due to a dependency update.

Provide pictures/videos of the behavior before and after these changes (optional)

Have you added or updated relevant tests?

  • Yes
  • No changes are needed

Have you added or updated relevant documentation?

  • Yes
  • No changes are needed

Are there any additional TODOs before this PR is ready to go?

TODOs:
None

@JakeWags JakeWags requested a review from NateLanza August 8, 2024 21:10
Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for upset2 ready!

Name Link
🔨 Latest commit 329814a
🔍 Latest deploy log https://app.netlify.com/sites/upset2/deploys/66b65087bfc1ca00086a7260
😎 Deploy Preview https://deploy-preview-377--upset2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@NateLanza NateLanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One operator can be simplified, otherwise LGTM

packages/upset/src/components/custom/PlotInformation.tsx Outdated Show resolved Hide resolved
Co-authored-by: NateLanza <58234814+NateLanza@users.noreply.github.com>
@JakeWags JakeWags merged commit bbef28c into main Aug 9, 2024
7 checks passed
@JakeWags JakeWags deleted the fix-build-errors branch August 9, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants