From 90d632cfbb2a28a641defbd0dc54aec17d2a928d Mon Sep 17 00:00:00 2001 From: Jake Wagoner Date: Thu, 29 Aug 2024 10:13:52 -0600 Subject: [PATCH] Fix deviation scale being shifted by 1/2 attribute bar width --- packages/upset/src/components/Columns/DeviationBar.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/upset/src/components/Columns/DeviationBar.tsx b/packages/upset/src/components/Columns/DeviationBar.tsx index 58b3e16f..89efc0c3 100644 --- a/packages/upset/src/components/Columns/DeviationBar.tsx +++ b/packages/upset/src/components/Columns/DeviationBar.tsx @@ -18,7 +18,7 @@ export const DeviationBar: FC = ({ deviation }) => { const dimensions = useRecoilValue(dimensionsSelector); const deviationScale = useRecoilValue(deviationScaleAtom); - deviationScale.range([0, dimensions.attribute.width / 2]); + deviationScale.range([0, dimensions.attribute.width]); return ( = ({ deviation }) => { 0) ? positiveDeviation : negativeDeviation} transform={translate( - deviation > 0 ? 0 : -deviationScale(Math.abs(deviation)), + deviation > 0 ? 0 : -deviationScale(Math.abs(deviation)) + dimensions.attribute.width / 2, 0, )} height={dimensions.attribute.plotHeight} - width={deviationScale(Math.abs(deviation))} + width={deviationScale(Math.abs(deviation)) - dimensions.attribute.width / 2} /> );