Merge pull request #387 from visdesignlab/386-deviation-scale-fix

Fix deviation scale being shifted by 1/2 attribute bar width
visdesignlab · Aug 29, 2024 · 256bf35 · 256bf35
2 parents 624db5c + 90d632c
commit 256bf35
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/upset/src/components/Columns/DeviationBar.tsx b/packages/upset/src/components/Columns/DeviationBar.tsx
@@ -18,7 +18,7 @@ export const DeviationBar: FC<Props> = ({ deviation }) => {
   const dimensions = useRecoilValue(dimensionsSelector);
 
   const deviationScale = useRecoilValue(deviationScaleAtom);
-  deviationScale.range([0, dimensions.attribute.width / 2]);
+  deviationScale.range([0, dimensions.attribute.width]);
 
   return (
     <g
@@ -30,11 +30,11 @@ export const DeviationBar: FC<Props> = ({ deviation }) => {
       <rect
         fill={(deviation > 0) ? positiveDeviation : negativeDeviation}
         transform={translate(
-          deviation > 0 ? 0 : -deviationScale(Math.abs(deviation)),
+          deviation > 0 ? 0 : -deviationScale(Math.abs(deviation)) + dimensions.attribute.width / 2,
           0,
         )}
         height={dimensions.attribute.plotHeight}
-        width={deviationScale(Math.abs(deviation))}
+        width={deviationScale(Math.abs(deviation)) - dimensions.attribute.width / 2}
       />
     </g>
   );