Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Vimeo support to VideoJS #152

Open
lewismalpas opened this issue Sep 28, 2020 · 2 comments
Open

Adding Vimeo support to VideoJS #152

lewismalpas opened this issue Sep 28, 2020 · 2 comments

Comments

@lewismalpas
Copy link

Hi,

I'm hoping to use the plugin to extend VideoJS to support Vimeo URLs, from my reading it seems this plugin is no longer maintained and does not work with the latest release of VideoJS - Can anyone advise on how I can add support for Vimeo URLs (e.g https://vimeo.com/290702348)?

Is the only way to have a Vimeo Pro account which provides you with the MP4 links which I can then use directly with VideoJS without requiring any additional plugins?

Thank you,
Lewis

Results

Expected

Support for Vimeo hosted videos via VideoJS player

Actual

Player is setup, however Vimeo video is not displayed and cannot be played (See errors below)

Error output

  1. 'Uncaught Error: Illegal component, "Vimeo"; techs must be registered using Tech.registerTech().'
  2. 'VIDEOJS: ERROR: SyntaxError: Unexpected end of JSON input'

Additional Information

Please include any additional information necessary here. Including the following:

versions

videojs

v7.8.4

browsers

Testing in Chrome (v85)

plugins

None

@gkatsev
Copy link
Member

gkatsev commented Sep 29, 2020

The main issue why it's not really maintained is because several years ago Vimeo changed their terms of usage to disallow disabling their controls and showing custom controls on top. Unless they've changed that, it's unlikely that we will spend the time to fix the plugin, especially since it definitely has less usage compared to the youtube plugin.

However, if someone fixes it, we'd be happy to merge and release. The caveat is that we won't accept something that doesn't comply with Vimeo's terms of use.

@gkatsev
Copy link
Member

gkatsev commented Sep 29, 2020

Looks like someone is maintaining a fork #151 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants