Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old code on npm #116

Open
daniplaninc opened this issue Jul 13, 2017 · 1 comment
Open

Old code on npm #116

daniplaninc opened this issue Jul 13, 2017 · 1 comment

Comments

@daniplaninc
Copy link

daniplaninc commented Jul 13, 2017 •
edited by gkatsev
Loading

The npm seems to have a version that doesn't work ($.getJSON not defined as referenced in #74 ) which was fixed in master (as per @gkatsev 's comment) but as far as I can see, not released. I tried downloading the source and building it myself, but I get the error Cannot find module @vimeo/player

Am I doing something wrong?
@daniplaninc
Copy link
Author

daniplaninc commented Jul 17, 2017 •
edited
Loading

I managed to make it work by taking the latest .min JS from /dist and requiring that directly.

But it would be nice to be able to have this as a dependency through NPM instead..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daniplaninc