Skip to content

Latest commit

 

History

History
67 lines (52 loc) · 1.28 KB

PULL_REQUEST_TEMPLATE.md

File metadata and controls

67 lines (52 loc) · 1.28 KB

Link to Ticket: https://steel-ventures.atlassian.net/browse/VTN-XXXX

Reviewers

Please remove reviewers not appropriate

Vertical:

  • Media - @deloreanz (Carter)
  • Politics - @1heiggins (Haig)
  • Legal - @steveshaffer
  • Public Safety - @jtveritone (Jason)
  • Ecosystem - @adamweiner
  • Edge - @jay-a-brown

Horizontal:

  • Apps - @deloreanz (Carter)
  • Platform - @jtveritone (Jason)

Infrastructure:

  • @nimajalali
  • @tamsky

Engineering/Architecture:

  • @albertcbrown
  • @jdubyou (James W)

Purpose

What Changed

How should we monitor this?

What should we be monitoring due to this change?

Testing

  • Regression document updates
  • (UI) RainforestQA updated & results shared
  • (UI) Selenium for happy path updated
  • Unit Tests & results shared
  • Runscope updated if API

Extensibility

  • Events Defined
  • Ability to extend & re-use UI
  • APIs defined and leveraged

Hygiene

  • README.md updated
  • Runbooks updated
  • Code is documented (Clean Code book)
  • Tested in dev environment
  • New APIs are documented in Swagger
  • DB Rollback/roll-forward scripts
  • Monitoring is defined

Performance

  • Scaling understood
  • Typical and peak loads defined