Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing arrays with object type raise FloatingPoint errors not catchable by numpy #33

Open
yohanchatelain opened this issue May 17, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@yohanchatelain
Copy link
Collaborator

When the dtype is not a numeric data type, numpy may raise ZeroDivisionError instead of RuntimeWarning.

/usr/local/lib/python3.11/site-packages/significantdigits/_significantdigits.py:259:
RuntimeWarning: invalid value encountered in divide
return operator(x, y_reshaped)

A solution would be to cast the dtype to a numeric dtype before doing any calculations.

@yohanchatelain yohanchatelain added the bug Something isn't working label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant