Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

math functions (sinus/radians etc.) #224

Open
stefanslangen opened this issue Aug 1, 2019 · 2 comments
Open

math functions (sinus/radians etc.) #224

stefanslangen opened this issue Aug 1, 2019 · 2 comments

Comments

@stefanslangen
Copy link

Is it correct that some math functions are not supported yet if they occur in the Excel sheet (for example sinus, cosinus, radians etc.)?

I am getting the following error:

Traceback (most recent call last):
File "C:\ProgramData\Anaconda3\lib\site-packages\koala\Spreadsheet.py", line 982, in cell_evaluate
vv = eval(cell.compiled_expression)
File "", line 1, in
NameError: name 'radians' is not defined

@Brad-eki
Copy link
Collaborator

Brad-eki commented Aug 2, 2019

@stefanslangen, the functions supported are largely listed here;
https://github.com/vallettea/koala/blob/master/koala/functions.json

In case that list hasn't been updated I have done a search through the code to see if they have been implemented. I have found those functions are not yet implemented.

You are welcome to implement them if you like. There is code in this commit which might inspire you as to how;
3de965c

@danielsjf
Copy link
Collaborator

Listing the functions for future reference:

  • COS
  • COSH
  • ACOS
  • ACOSH
  • IMCOS
  • IMCOSH
  • SIN
  • SINH
  • ASIN
  • ASINH
  • IMSIN
  • IMSINH
  • RADIANS

According to this list, there are 476 known and documented excel functions (extracted in that file). Maybe we could write a small code to check how many of those functions we have implemented already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants