Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for requestTime() #8

Open
tsathishkumar opened this issue Oct 22, 2018 · 5 comments
Open

Add support for requestTime() #8

tsathishkumar opened this issue Oct 22, 2018 · 5 comments
Assignees
@tsathishkumar
Labels
enhancement New feature or request

Comments

@tsathishkumar
Copy link
Owner

Add feature to respond for requestTime calls from nodes.
@tsathishkumar tsathishkumar added the enhancement New feature or request label Oct 22, 2018
@tsathishkumar tsathishkumar self-assigned this Oct 22, 2018
@tsathishkumar tsathishkumar mentioned this issue Oct 22, 2018
Closed
tsathishkumar added a commit that referenced this issue Nov 22, 2018
@tsathishkumar
#8 Added support for I_TIME requests from sensors
598b8a3
@tsathishkumar
Copy link
Owner Author

@flatsiedatsie I have added the feature in the latest commit. Could you do a round of testing and let me know if it works. Thanks.

@flatsiedatsie
Copy link
Contributor

I will!

@flatsiedatsie
Copy link
Contributor

flatsiedatsie commented Nov 29, 2018 •
edited
Loading

My alarm clock node does not seem to pick up the time :-(

I couldn't find any code in the project relating to "I_TIME"?

I had a look at the documentation, and it seems a time request will be something like.

*; (NODE_ID)
*; (CHILD_ID)
3; (internal request)
0; (if we request an ACK or not)
1; (I_TIME type: the time is being requested)

It should return "local time adjusted for DST."

@flatsiedatsie
Copy link
Contributor

flatsiedatsie commented Nov 29, 2018 •
edited
Loading

Hey, wait, I think it works now!

The time seems to be one hour off?

pi@gateway:~ $ date
Thu Nov 29 15:00:10 CET 2018

But the time on the alarm clock says 14:00.

Perhaps it's a summertime/wintertime thing?

@tsathishkumar
Copy link
Owner Author

I assume so. I think the time sent by the controller is UTC and UTC is 1 hr behind CET.

@flatsiedatsie flatsiedatsie mentioned this issue Dec 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsathishkumar tsathishkumar

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flatsiedatsie @tsathishkumar