Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate whether Paths.get is safe across platforms #124

Open
travisbrown opened this issue Sep 7, 2020 · 0 comments
Open

Investigate whether Paths.get is safe across platforms #124

travisbrown opened this issue Sep 7, 2020 · 0 comments
Labels
question Further information is requested

Comments

@travisbrown
Copy link
Owner

Right now we use Paths.get(pathToken) for local imports during parsing. The parser ensures that only / will be used as a separator, but I'm not sure I know for a fact that Paths.get is guaranteed to handle / appropriately on all platforms.

Alternatively we could switch away from using Path in our representation of local imports, which I think might be the better choice.
@travisbrown travisbrown added the question Further information is requested label Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@travisbrown