Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace elliptic with noble curves #42

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

ieow
Copy link

@ieow ieow commented Sep 25, 2024

Motivation and Context

Jira Link:

Description

Replace elliptic with @nobles/curves

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ieow ieow marked this pull request as draft September 25, 2024 06:50
@@ -70,7 +70,7 @@
"typescript": "^5.5.3"
},
"dependencies": {
"elliptic": "^6.5.5"
"@noble/curves": "^1.6.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you only need secp256k1, you should be able to use @noble/secp256k1 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants