replace envd destroy with envd down

[Triple-Z]

ref: #422 (comment)

maybe down is a better word than destroy:

1. docker-compose uses it.
2. down is the antonym for up.
3. destroy is easy to typo :(

[gaocegege]

We will stop and remove the container if we run envd destroy, if we use down, I am afraid that users may think the container is just shutdown, and not be removed.

cc @terrytangyuan @VoVAllen

[Triple-Z]

In fact, docker-compose down also removes the containers.

[gaocegege]

LGTM

[terrytangyuan]

Sounds good.

[gaocegege]

I think we should merge it in 0.2.0 since it has the breaking change.

[Triple-Z]

Agreed.

[popfido]

Or support both destroy and down to keep backward compatibility.

[VoVAllen]

To me, down is more likely halt instead of destroy.

I think down is an ambiguous term. I prefer stop/halt + destroy over down

Reference:

• AWS: stop vs terminate
• vagrant: halt vs destroy
• docker-compose: stop vs down

[Triple-Z]

cc @gaocegege

[gaocegege]

I think it is great to keep two cmds. One is for shutdown the ctr. The other is to remove them.

I have no objection to the name

[gaocegege]

How about stop and destroy?

[Triple-Z]

Change pause to stop?

[gaocegege]

Pause/resume actually freezes/resumes the processes in the container. Stop kills the processes. It is slightly different. 🤔

[Triple-Z]

As the discussions above, can we add the envd down command as the alias of envd destroy in the future versions?

[gaocegege]

SGTM!