From f51990e82aaae662d923f9f6a1e6d8bd53c6f7bd Mon Sep 17 00:00:00 2001 From: Keming Date: Fri, 4 Aug 2023 16:41:59 +0800 Subject: [PATCH] feat: add envd app exit handler (#1722) * feat: add envd app exit handler Signed-off-by: Keming * rm commented code Signed-off-by: Keming * fix test Signed-off-by: Keming --------- Signed-off-by: Keming --- pkg/app/app.go | 6 ++++++ pkg/driver/docker/docker.go | 6 +++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/pkg/app/app.go b/pkg/app/app.go index 95b9f4509..3a56d70f4 100644 --- a/pkg/app/app.go +++ b/pkg/app/app.go @@ -155,6 +155,12 @@ func New() EnvdApp { return nil } + internalApp.ExitErrHandler = func(context *cli.Context, err error) { + if err != nil { + logrus.Fatal(err) + } + } + return EnvdApp{ App: *internalApp, } diff --git a/pkg/driver/docker/docker.go b/pkg/driver/docker/docker.go index f16cee47f..3d3d1a5ae 100644 --- a/pkg/driver/docker/docker.go +++ b/pkg/driver/docker/docker.go @@ -96,7 +96,11 @@ func NormalizeName(s string) (string, error) { } // remove the spaces s = strings.ReplaceAll(s, " ", "") - return s, nil + name, err := reference.Parse(s) + if err != nil { + return "", errors.Wrapf(err, "failed to parse the name '%s', please provide a valid image name", s) + } + return name.String(), nil } func (c dockerClient) ListImage(ctx context.Context) ([]types.ImageSummary, error) {